Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix disabledTime not working when there is no default value #680

Merged
merged 10 commits into from
Oct 7, 2023
Merged

fix: fix disabledTime not working when there is no default value #680

merged 10 commits into from
Oct 7, 2023

Conversation

yoyo837
Copy link
Member

@yoyo837 yoyo837 commented Sep 29, 2023

@vercel
Copy link

vercel bot commented Sep 29, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
picker ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2023 3:37am

@yoyo837
Copy link
Member Author

yoyo837 commented Sep 29, 2023 •
edited
Loading

@qyjandroid @SnowingFox @Yuiai01 @MadCcc @zombieJ Pleas help to check this.

@codecov
Copy link

codecov bot commented Sep 29, 2023 •
edited
Loading

Codecov Report

Merging #680 (27e375b) into master (2f801d1) will increase coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head 27e375b differs from pull request most recent head 1370d79. Consider uploading reports for the commit 1370d79 to get more accurate results

@@            Coverage Diff             @@
##           master     #680      +/-   ##
==========================================
+ Coverage   98.90%   98.94%   +0.04%     
==========================================
  Files          56       56              
  Lines        2457     2457              
  Branches      733      734       +1     
==========================================
+ Hits         2430     2431       +1     
+ Misses         25       24       -1     
  Partials        2        2
Files Coverage Δ
src/panels/DatetimePanel/index.tsx 100.00% <100.00%> (+1.44%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yoyo837 yoyo837 changed the title fix: fix some time disabledTime not working fix: fix disabledTime not working when there is no default value Sep 29, 2023
@yoyo837 yoyo837 mentioned this pull request Sep 29, 2023
Merged
@yoyo837 yoyo837 force-pushed the fix-disabled-time branch from e975441 to 8cd0de2 Compare October 5, 2023 15:58
@yoyo837 yoyo837 force-pushed the fix-disabled-time branch from 8cd0de2 to 85e57bb Compare October 7, 2023 01:21
@qyjandroid
Copy link

@qyjandroid @SnowingFox @Yuiai01 @MadCcc @zombieJ Pleas help to check this.
image

这里默认返回0，如果禁用0-5，感觉还是会默认设置为00:00:00，应该还存在问题。

@yoyo837
Copy link
Member Author

yoyo837 commented Oct 7, 2023

@qyjandroid @SnowingFox @Yuiai01 @MadCcc @zombieJ Pleas help to check this.
image

这里默认返回0，如果禁用0-5，感觉还是会默认设置为00:00:00，应该还存在问题。

改了下看看行不行

@qyjandroid
Copy link

@qyjandroid @SnowingFox @Yuiai01 @MadCcc @zombieJ Pleas help to check this.
image

这里默认返回0，如果禁用0-5，感觉还是会默认设置为00:00:00，应该还存在问题。

改了下看看行不行

应该没啥问题了

@yoyo837
Copy link
Member Author

yoyo837 commented Oct 7, 2023

合并 #666 的差异一起看, 变动是这些:

image

image

@yoyo837 yoyo837 merged commit a87a843 into master Oct 7, 2023
8 checks passed
@yoyo837 yoyo837 deleted the fix-disabled-time branch October 7, 2023 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yuiai01 Yuiai01 Yuiai01 approved these changes

@MadCcc MadCcc MadCcc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DatePicker 中disabledTime 禁用问题
4 participants
@yoyo837 @qyjandroid @MadCcc @Yuiai01